-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose client closed flag publicly #7365
Expose client closed flag publicly #7365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdk/eventhub/Microsoft.Azure.EventHubs/tests/Client/MiscTests.cs
Outdated
Show resolved
Hide resolved
…nto serkar.AddIsClosedOnClients
@@ -20,6 +20,9 @@ public abstract class ClientEntity | |||
static int nextId; | |||
RetryPolicy retryPolicy; | |||
|
|||
/// <summary /> | |||
protected bool closeCalled = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this field protected and named this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed to notice your comment. I see your point. I will remove it and set the property setter as protected instead in another PR.
Adding bool IsClosed on EventHubClient, PartitionSender, and PartitionReceiver.